Fix error triggering after duplicating a block making it unselectable.

[delowardev]

Fixes: #38759

Description

After duplicating a block from List View, it doesn't select that block and throws an error.

Testing Instructions

Screenshots

Types of changes

Bug fix

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• I've tested my changes with keyboard and screen readers.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
• I've updated related schemas if appropriate.

[talldan]

Thanks for looking into this issue @delowardev.

The more I look at the code in trunk, the more it looks broken, and I'm also not sure what the right way to fix it is.

As you mention, selectEditorBlocks is sometimes called with clientIds as a param, sometimes with an event as a param. I'm also not sure what the original intention of the call to select blocks was in the block settings dropdown. Perhaps to prevent a focus loss?

I'm going to add some reviewers that have worked on this in the past for some further opinions. If I recall correctly @adamziel and @noisysocks worked on the BlockSettingsDropdown in List View.

[noisysocks]

I'm also not sure what the original intention of the call to select blocks was in the block settings dropdown. Perhaps to prevent a focus loss?

I'm not 100% sure either. This bit of the codebase has had a lot of iteration so very possible it's not used anymore. Feel free to remove it and see what happens 😀 just be sure to test List View in the site editor, post editor, widgets editor, navigation block toolbar, and experimental navigation editor.

[talldan]

After looking at the code for a while, I think I have a good idea for a fix.

It looks like all that needs to be changed is this line:

gutenberg/packages/block-editor/src/components/list-view/block.js

Line 239 in 9543b72

__experimentalSelectBlock={ selectEditorBlock }

Which can be changed to this:

__experimentalSelectBlock={ selectBlock }

Reasoning: selectBlock already accepts a clientId as the first param and doesn't expect an event, so seems to match the code in BlockSettingsDropdown. I can't be sure, but I think this is probably what was intended, but someone made a typo and accidentally typed selectEditorBlock.

[talldan]

That seems to work well now, thanks for spotting the bug and fixing it.