Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover block: update deprecated gradient fixture #38728

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Feb 11, 2022

Description

This PR regenerates the Cover Block gradient deprecation fixture because the attribute "isDark":false should have had a corresponding is-light classname on the container.

This was a human copy 🍝 error.

I generated the new fixture by rolling back 4bfd7b3 (pre #38392) and copying the Cover Block code from the editor very carefully this time.

The only other change is the choice of preset gradient color: from luminous-dusk to electric-grass, which is way cooler. ☮️

See: #38685 (comment) and #38392 (comment)

Props to @talldan for raising it

Testing Instructions

Check that the core__cover__gradient__deprecated-8.json block validity prop isValid is true

The fixture tests (all E2Es) should pass.

Types of changes

Fixing bad fixture HTML

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

… the attribute `"isDark":false` should have a corresponding `is-light` classname on the container.
@ramonjd ramonjd added [Type] Code Quality Issues or PRs that relate to code quality [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Feb 11, 2022
@ramonjd ramonjd self-assigned this Feb 11, 2022
@ramonjd ramonjd requested a review from talldan February 11, 2022 06:13
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it 🎉

@talldan talldan merged commit 95d4b92 into trunk Feb 11, 2022
@talldan talldan deleted the update/cover-block-gradient-deprecation branch February 11, 2022 07:22
@github-actions github-actions bot added this to the Gutenberg 12.7 milestone Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants