Block Directory: Fix the block activation when metadata registered on server #38697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Bug
gziolo
changed the title
|
Size Change: +199 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
|
I see that an unit test is failing. I’m looking into it. |
gziolo
force-pushed
the
fix/block-directory-activation-error
branch
2 times, most recently
from
a625ec1 to
85a35b7
Compare
|
I have added logic that covers also all those blocks that don't have PHP logic that register them on the server. Example block to use for testing:
We need to account for 404 responses when the block is registered on the client. The good news is that client-side only blocks will work by design 😄 |
ryelle
approved these changes
Feb 10, 2022
| 'styles', | ||
| 'example', | ||
| 'variations', | ||
| ].reduce( ( accumulator, key ) => { |
There was a problem hiding this comment.
It took me a minute to parse that this is filtering out response properties - is there a reason we can't use the default response? or use _fields when requesting the API endpoint?
There was a problem hiding this comment.
I had a version with _fields before. I can switch back to it. Do you know how I also get rid of other meta fields like _links?
There was a problem hiding this comment.
Addressed in e19bc49 👍🏻
I noticed that the package already uses loodash so I went with pick( response, metadataFields ) that should make it easier to read and removes _links field from the response.
gziolo
force-pushed
the
fix/block-directory-activation-error
branch
from
85a35b7 to
e19bc49
Compare
gziolo
force-pushed
the
fix/block-directory-activation-error
branch
from
c7fa533 to
5635e3f
Compare
gziolo
added a commit
that referenced
this pull request
Feb 22, 2022
… server (#38697) * Block Directory: Fix the block activation when metadata registered only on server * Add proper mocking for Block Directory unit tests * Handle the case when the block is not registered on the server * Use `_fields` with REST API call and `pick` to filter response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #38245.
The action that installs the block from Block Directory triggers an additional REST API call to get the corresponding metadata for the newly installed plugin on the server.
Testing Instructions
Step-by-step reproduction instructions
Screenshots
Screen.Recording.2022-02-10.at.11.29.35.mov
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).