Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: add CHANGELOG entries for recent TreeGrid improvements #38661

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Components: add CHANGELOG entries for recent TreeGrid improvements #38661

merged 1 commit into from
Feb 9, 2022

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented Feb 9, 2022

Description

When making changes to the @wordpress/components package, it's good habit to add a CHANGELOG entry.

This PR retroactively adds a couple of missing entries for some past PRs.

Related to #38639 and #37983

Types of changes

Docs

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@ciampo ciampo added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components [Feature] Component System WordPress component system labels Feb 9, 2022
@ciampo ciampo requested review from talldan and alexstine February 9, 2022 09:32
@ciampo ciampo self-assigned this Feb 9, 2022
@ciampo ciampo requested a review from ajitbohra as a code owner February 9, 2022 09:32
@ciampo ciampo mentioned this pull request Feb 9, 2022
Merged
8 tasks
alexstine
alexstine approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about these. I will eventually get it down.

@ciampo ciampo merged commit 6fb6f0e into trunk Feb 9, 2022
@ciampo ciampo deleted the fix/components-missing-changelog-entry branch February 9, 2022 16:42
@github-actions github-actions bot added this to the Gutenberg 12.6 milestone Feb 9, 2022
@ciampo
Copy link
Contributor Author

ciampo commented Feb 9, 2022

Sorry about these. I will eventually get it down.

It's fine! It's easy to leave these changes behind, and there's no automated check around them either :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexstine alexstine alexstine approved these changes

@talldan talldan Awaiting requested review from talldan

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@ciampo ciampo

Labels
[Feature] Component System WordPress component system [Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 12.6
Development

Successfully merging this pull request may close these issues.
2 participants
@ciampo @alexstine