Ensure placeholder description is read by VoiceOver #38366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Focus] Accessibility (a11y)
|
Size Change: +1.42 kB (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
|
@tellthemachines This works fine in my testing. Nice! Happy to approve after tests are made stable. |
This was referenced Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When inserting or selecting a block with a placeholder, VoiceOver doesn't read out the description, so there's often not enough context to know what the controls are supposed to do.
This PR changes the placeholder markup slightly to wrap the contents in a fieldset, and the description in a legend. This causes the description to be read by VoiceOver when the first control is focused.
Testing Instructions
I haven't checked with any Windows screen readers, but previous testing shows this isn't an issue on NVDA, so it would be good to double-check this doesn't make the experience worse for Windows users.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).