Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version required before gutenberg_safe_style_attrs filter can be removed #38359

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Description

Changes made to the gutenberg_safe_style_attrs filter in #31641 and #36280 changed the minimum version requirement before the filter could be removed to be 5.9. This PR just updates the comment to reflect this requirement.

Testing Instructions

Double-check the WP version that contains the changes from #31641 and #36280.

Types of changes

Typo fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@ramonjd
Copy link
Member

ramonjd commented Jan 31, 2022

Double-check the WP version that contains the changes from #31641 and #36280.

#31641

Changes made it into 5.9 (not 5.8)

#36280

Changes are visible in 5.9 but not 5.8 (the filter entry for example)

LGTM

@aaronrobertshaw aaronrobertshaw merged commit 1951c4f into trunk Jan 31, 2022
@aaronrobertshaw aaronrobertshaw deleted the update/safe-style-attrs-filter-comment branch January 31, 2022 03:43
@github-actions github-actions bot added this to the Gutenberg 12.6 milestone Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants