Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override Site Editor URLs to use plugin page #38232

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Conversation

Mamaduka
Copy link
Member

Description

PR add filter to override wp-admin/site-editor.php paths with themes.php?page=gutenberg-edit-site. It should prevent plugin users from accidentally accessing editor shipped with the core in 5.9.

Testing Instructions

  1. Go to Themes and activate any block theme.
  2. Click on the "Customize" button.
  3. It should take you to the themes.php?page=gutenberg-edit-site page.

Types of changes

Bugfix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@Mamaduka Mamaduka self-assigned this Jan 26, 2022
@Mamaduka Mamaduka added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended labels Jan 26, 2022
@Mamaduka Mamaduka requested a review from aristath January 26, 2022 06:57
@Mamaduka
Copy link
Member Author

Thank you, Ari.

@Mamaduka Mamaduka merged commit a4ab23b into trunk Jan 26, 2022
@Mamaduka Mamaduka deleted the fix/site-editor-urls branch January 26, 2022 12:07
@github-actions github-actions bot added this to the Gutenberg 12.5 milestone Jan 26, 2022
@noisysocks
Copy link
Member

Why can't we use site-editor.php? I think that the Gutenberg plugin and Core should converge onto a single URL. For example, we don't use different URLs depending on whether the plugin is active for the widgets block editor or post block editor.

@Mamaduka
Copy link
Member Author

The site-editor.php doesn't exist in WP 5.8, and the plugin still has to support that version.

We'll remove a separate page when the minimum required version is 5.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants