Always allow accessing edit.php?post_type=wp_navigation page #38170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Navigation block is supported in both block themes and classic themes, so it is incorrect to only allow access to edit.php?post_type=wp_navigation when the current theme is a block theme. This fixes a bug where clicking on 'Manage menus' in the toolbar of a Navigation block takes you an error page when running a classic theme.
noisysocks
added
[Type] Bug
noisysocks
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38118.
The Navigation block is supported in both block themes and classic themes, so it is incorrect to only allow access to
edit.php?post_type=wp_navigationwhen the current theme is a block theme.This fixes a bug where clicking on 'Manage menus' in the toolbar of a Navigation block takes you an error page when running a classic theme.
It's the same fix as what's in https://core.trac.wordpress.org/ticket/54889 but in Gutenberg. We need to make the change in both codebases so that older versions of WP running the Gutenberg plugin don't have the issue.