Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tested up to WP 5.9 #38162

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Tested up to WP 5.9 #38162

merged 1 commit into from
Jan 24, 2022

Conversation

walbo
Copy link
Member

@walbo walbo commented Jan 23, 2022

Description

  • Update the tested up to version in the readme file.
  • Update the tested up to version in the create block templates.
  • Update the tested up to version in the create block tutorial template

Types of changes

Non breaking change

@walbo walbo added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label Jan 23, 2022
@walbo walbo requested review from gziolo and mkaz as code owners January 23, 2022 18:35
@gziolo gziolo requested a review from a team January 24, 2022 07:05
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. We should look at updating the minimum supported version to 5.8 a few weeks after 5.9 lands

@gziolo
Copy link
Member

gziolo commented Jan 24, 2022

Makes sense to me. We should look at updating the minimum supported version to 5.8 a few weeks after 5.9 lands

Can we do it now? Do you think there is a lot of value in using WordPress 5.7 with the most recent version of Gutenberg from the plugin's mission perspective? It creates a ton of maintenance burden, so I would consider dropping support when beta 1 for the next major release gets published. It means that now during 5.9 RC, we would support only 5.8. We would update the minimum version to 5.9 when 6.0 Beta 1 is ready, and so on.

@youknowriad
Copy link
Contributor

@gziolo At this point it doesn't matter match for both cases. That burden is not going to be felt because 5.9 is almost "done" and by the time we land a PR to update the minimum version and ship a plugin release, 5.9 is going to be out in the wile 🤷‍♂️

If we are to change the policy for the future, that's something else (say by the start of 6.0 beta, we remove support for 5.8)

@gziolo
Copy link
Member

gziolo commented Jan 24, 2022

If we are to change the policy for the future, that's something else (say by the start of 6.0 beta, we remove support for 5.8)

Yes, this is exactly what I propose. At the same time we wouldn't have to wait a few more weeks to drop support for 5.7.

@walbo walbo merged commit 81f4a7e into trunk Jan 24, 2022
@walbo walbo deleted the update/tested-up-to-5-9 branch January 24, 2022 14:59
@github-actions github-actions bot added this to the Gutenberg 12.5 milestone Jan 24, 2022
@Mamaduka
Copy link
Member

I think this PR broke the performance test on the trunk.

@walbo
Copy link
Member Author

walbo commented Jan 25, 2022

I think this PR broke the performance test on the trunk.

Looks like the performance tests uses the Tested up to to define what version of WP to use in https://github.com/WordPress/gutenberg/blob/trunk/.github/workflows/performance.yml#L50

Since 5.9 isn't released before later today the WP version doesn't exists. Should the test use latest istead? (so it fetches https://wordpress.org/wordpress-latest.zip)

cc @youknowriad

@youknowriad
Copy link
Contributor

the test shouldn't use latest because it would break with old branches. I guess we just merged this PR too soon, so we should just wait, it's just one day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants