Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the Global Styles Presets #38129

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Document the Global Styles Presets #38129

merged 2 commits into from
Jan 26, 2022

Conversation

youknowriad
Copy link
Contributor

Blocked by #35619

This PR adds initial documentation for the global styles presets feature (for block themes).

While working on this, I noticed a number of docs that look similar or duplicate each other, I wonder if it's intentional and whether we need to consolidate at some point:

  • Block Themes documentation and folder structure is duplicated in two files.
  • Theme.json config docs (settings and styles...) are also duplicated, theme theme-json.md file and the create-block-theme.md file.

@carolinan
Copy link
Contributor

We are moving what's "stable" in 5.9 to the theme developer handbook https://developer.wordpress.org/themes/block-themes/
so these original documents can absolutely be "cleaned up". I don't think they can be removed since there may be many external, incoming links.

Copy link
Contributor

@ryanwelcher ryanwelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs look good to me. Just to confirm that this feature doesn't currently work, correct? I was not able to get it working using the docs as a reference.

Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Riad!

docs/how-to-guides/themes/create-block-theme.md Outdated Show resolved Hide resolved
@youknowriad
Copy link
Contributor Author

@ryanwelcher yes, it only works in the linked PR #35619

@youknowriad youknowriad merged commit 936068f into trunk Jan 26, 2022
@youknowriad youknowriad deleted the add/styles-presets-doc branch January 26, 2022 08:56
@github-actions github-actions bot added this to the Gutenberg 12.5 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants