Latest Posts: Fix featured image alignment label position #38125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Latest Posts
|
Size Change: -105 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
Nice, thanks so much for running with my brief suggestion on that other thread. Even now, this is a big improvemment, but spacing wise it's a bit big, likely because a small version of the actual toolbar is being included here: In a perfect world, we'd find a way to leverage the same component that's used for border "style":
I sense that might require a bigger refactor, and since the Latest Posts block deserves a bigger inspector refresh entirely, it seems like we could/should apply a smaller bandaid in the mean time. I looked at whether there was some low-hanging CSS we could apply, but due to how the toggled background is drawn, it gets hacky quick (and suggests the block toolbar itself needs a refactor 😱 ). So perhaps a good temporary fix is to just move the label above, as you did, but keep the border, maintaining the appearance of an embedded mini-block-toolbar. What do you think? |
I also did this and came to the same conclusion.
Sounds good. I will remove border reset 👍 |
jasmussen
reviewed
Jan 21, 2022
jasmussen
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
Nice, looks way better than before:
As noted, the whole inspector here needs a bit of a refresh (with some unread ideas shared here), but that's a future bridge to cross. In the mean time, this makes it look not broken.
If you'd like, feel free to slipstream a border-radius: $radius-block-ui; in, so the dark border is rounded like the block toolbar is. Otherwise, ship it! Thanks.
|
I'm happy to work on the whole inspector refresh. I just thought you were still working on the final touches. |
You've done so much, and I'm sure you have more important things to work on! I want to be clear that I like to share future wishlist items in reviews as context, I find it to be valuable for when we are shipping small iterative improvements, striking that balance between improving what's there, but not forgetting more work is on the docket. For latest posts, when the mockup feels right, I'll create a new ticket for anyone to pick up. If we end up collaborating again, I'd enjoy that as I always do! But please don't feel like you have to take it on. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR fixes the Latest Posts block featured image alignment label position.
It also removes the border from controls.How has this been tested?
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).