Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Late escape RSS block (#37878)" #38117

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Revert "Late escape RSS block (#37878)" #38117

merged 1 commit into from
Jan 20, 2022

Conversation

fullofcaffeine
Copy link
Member

@fullofcaffeine fullofcaffeine commented Jan 20, 2022 •
edited
Loading

This reverts #37878 as it caused RSS blocks to show HTML markup instead of the properly-rendered entries.

Testing

  1. Build Gutenberg and sync/install to your WP server/instance
  2. Create a new post/page
  3. Add a RSS block, use https://www.nasa.gov/rss/dyn/breaking_news.rss as a test feed
  4. You should see proper entries and no HTML markup at all rendered in the block inside the editor

cc @getdave @chad1008

@fullofcaffeine fullofcaffeine force-pushed the revert/late-escape-rss-block branch from 2988d2b to 7581a0e Compare January 20, 2022 23:20
noahtallen
noahtallen approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@noahtallen noahtallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this fix works 👍

@noahtallen noahtallen merged commit 019ad7f into trunk Jan 20, 2022
@noahtallen noahtallen deleted the revert/late-escape-rss-block branch January 20, 2022 23:47
@github-actions github-actions bot added this to the Gutenberg 12.5 milestone Jan 20, 2022
@noahtallen noahtallen mentioned this pull request Jan 20, 2022
Closed
8 tasks
noahtallen pushed a commit that referenced this pull request Jan 21, 2022
@fullofcaffeine @noahtallen
Revert "Late escape RSS block (#37878)" (#38117)
046ceb2 
This reverts commit 43ab543.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahtallen noahtallen noahtallen approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 12.5
Development

Successfully merging this pull request may close these issues.
2 participants
@fullofcaffeine @noahtallen