-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing props mediaPreview in the ReadMe #38114
Conversation
for Media Placeholder
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karolinakulinska! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
packages/block-editor/src/components/media-placeholder/README.md
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/media-placeholder/README.md
Outdated
Show resolved
Hide resolved
Thanks for contributing, @karolinakulinska. I left a few minor suggestions and restarted the checks. |
Co-authored-by: George Mamadashvili <[email protected]>
Co-authored-by: George Mamadashvili <[email protected]>
Thanks @Mamaduka . I have resolved your comments. Please check. |
@Mamaduka, can you have another look? |
@gziolo, it's good to merge 👍 |
Thank you for contributing 🙇♂️ |
Congratulations on your first merged pull request, @karolinakulinska! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
@karolinakulinska any chance you could confirm your WordPress.org account so that we can properly credit you in the WordPress 6.0 release next week? |
[image: image.png]
Hi !
I am sorry y for late reply
I created account
…On Thu, 19 May 2022 at 20:17, Jeffrey Paul ***@***.***> wrote:
@karolinakulinska <https://github.com/karolinakulinska> any chance you
could confirm your WordPress.org account so that we can properly credit you
in the WordPress 6.0 release next week?
—
Reply to this email directly, view it on GitHub
<#38114 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVEMKOGQZWFSNS44MY6H5C3VK2ATDANCNFSM5MNPJHRQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Description
Add missing props mediaPreview in the ReadMe for Media Placeholder Component
How has this been tested?
N/A
Types of changes
Documentation
Checklist: