Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing props mediaPreview in the ReadMe #38114

Merged
merged 3 commits into from
Apr 3, 2022

Conversation

karolinakulinska
Copy link
Contributor

@karolinakulinska karolinakulinska commented Jan 20, 2022

Description

Add missing props mediaPreview in the ReadMe for Media Placeholder Component

How has this been tested?

N/A

Types of changes

Documentation

Checklist:

  • I've included developer documentation if appropriate.

@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karolinakulinska! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 20, 2022
@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Jan 20, 2022
@Mamaduka
Copy link
Member

Thanks for contributing, @karolinakulinska.

I left a few minor suggestions and restarted the checks.

@karolinakulinska
Copy link
Contributor Author

Thanks for contributing, @karolinakulinska.

I left a few minor suggestions and restarted the checks.

Thanks @Mamaduka . I have resolved your comments. Please check.

@gziolo
Copy link
Member

gziolo commented Apr 1, 2022

@Mamaduka, can you have another look?

@Mamaduka
Copy link
Member

Mamaduka commented Apr 3, 2022

@gziolo, it's good to merge 👍

@gziolo gziolo merged commit 04639ad into WordPress:trunk Apr 3, 2022
@gziolo
Copy link
Member

gziolo commented Apr 3, 2022

Thank you for contributing 🙇‍♂️

@github-actions
Copy link

github-actions bot commented Apr 3, 2022

Congratulations on your first merged pull request, @karolinakulinska! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 13.0 milestone Apr 3, 2022
@jeffpaul
Copy link
Member

@karolinakulinska any chance you could confirm your WordPress.org account so that we can properly credit you in the WordPress 6.0 release next week?

@karolinakulinska
Copy link
Contributor Author

karolinakulinska commented May 22, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants