-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: update gray color palette to match base styles #38109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Feature] Component System
WordPress component system
[Package] Components
/packages/components
labels
Jan 20, 2022
Size Change: +6 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, thank you. In testing I could see no visual regressions as a result of this. It's of course hard to discern shades of gray, all the more reason to land it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As pointed out in #37551 (comment), currently the JS color palette in
@wordpress/components
doesn't match the one defined in the base styles. In particular:300
shade of gray is missing in the JS color palette200
shade in the the JS color palette has the wrong value (that value should be attributed to the300
shade)This PR updates the
200
and300
shades in the JS color palette, and also updates usages of those shades of gray so that the rendered color doesn't change.How has this been tested?
ToolsPanel
's border appear of the same color as in production (this can be done by comparing Storybook as well)Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).