-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capitalise the GitHub wordmark correctly in the Wordpress Gutenberg project. #38092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwilsoncc
requested review from
ajitbohra,
mkaz,
nerrad and
ntwb
as code owners
January 19, 2022 22:25
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
ntwb
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The GitHub wordmark includes a capital H, this replaces
Github
withGitHub
where it is safe to do so (documentation and comments).How has this been tested?
I haven't tested it.
I had to commit with the
--no-verify
flag as it seems there are some linting errors in some of the files touched but not on the lines changed.Screenshots
Types of changes
Documentation
Checklist:
*.native.js
files for terms that need renaming or removal).