Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include partialRight import from lodash in DimensionControl example #38088

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Include partialRight import from lodash in DimensionControl example #38088

merged 1 commit into from
Jan 20, 2022

Conversation

cr0ybot
Copy link
Contributor

@cr0ybot cr0ybot commented Jan 19, 2022 •
edited
Loading

Description

The partialRight import from lodash was missing from the example, which confused me when I was referencing it (especially having never used that particular utility before).

It would probably be better if the example didn't rely on such an opaque 3rd-party utility, but for now at least it's clear what is being used.

How has this been tested?

Screenshots

Types of changes

Documentation changes only.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@cr0ybot
Include partialRight import from lodash in DimensionControl example
5661e40 
The `partialRight` import from lodash was missing from the example, which confused me when I was referencing it (especially having never used that particular utility before).

It would probably be better if the example didn't rely on such an opaque 3rd-party utility, but for now at least it's clear what is being used.
@cr0ybot cr0ybot requested a review from ajitbohra as a code owner January 19, 2022 20:32
@Mamaduka Mamaduka added the [Type] Developer Documentation Documentation for developers label Jan 20, 2022
Mamaduka
Mamaduka approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks, @cr0ybot.

@Mamaduka Mamaduka merged commit 3ccd2d5 into WordPress:trunk Jan 20, 2022
@github-actions github-actions bot added this to the Gutenberg 12.5 milestone Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 12.5
Development

Successfully merging this pull request may close these issues.
2 participants
@cr0ybot @Mamaduka