Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some terms related to styles to the glossary #38076

Merged
merged 7 commits into from
Jan 19, 2022

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Jan 19, 2022

Adds some terms related to styles to the glossary with links to existing documentation: block styles, block supports, global styles.

@oandregal oandregal self-assigned this Jan 19, 2022
@oandregal oandregal requested review from a team and noisysocks and removed request for a team January 19, 2022 14:13
@oandregal oandregal added the [Type] Developer Documentation Documentation for developers label Jan 19, 2022
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oandregal 💯

docs/explanations/glossary.md Outdated Show resolved Hide resolved
Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling nits.

docs/explanations/glossary.md Outdated Show resolved Hide resolved
docs/explanations/glossary.md Outdated Show resolved Hide resolved

The CSS styles that are part of the block, either via its stylesheet or via the block markup itself. For example, a class attached to the block markup is considered block styles.

Compare to <a href="#global-styles">Global Styles</a>. In contraposition to "Global Styles", block styles are sometimes referred to as "Local Styles".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local Styles

Would it be useful to add an entry in this very glossary like so:

## Local Styles

See <a href="#block-styles">Block Styles</a>.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, missed this comment, sorry. #38083

@oandregal oandregal merged commit a31cf5f into trunk Jan 19, 2022
@oandregal oandregal deleted the add/style-terms-to-glossary branch January 19, 2022 17:08
@github-actions github-actions bot added this to the Gutenberg 12.5 milestone Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants