-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Editor: Fix template queries #38070
Conversation
Size Change: +16 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
This makes sense, are there any preloaded URLs that need to change or I guess we're not preloading any of that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The e2e test failure seems related maybe?
I think this is true for post editor. At least change doesn't affect the number of requests for template endpoint.
I don't think it's related. Looks like a flaky test - #37764. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
thank you! |
Description
Resolves #37969.
Similar to #36761
#36563 (comment)
How has this been tested?
You can test this by installing a theme from the theme directory called "Aino", which has several templates.
"Post with Portrait Featured image" - the Edit link is available
"Post without Comments" - the Edit link is available
Screenshots
Types of changes
Bugfix
Checklist:
*.native.js
files for terms that need renaming or removal).