Update micromodal to 0.4.10 to fix navigation close button
#38032
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +12 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Jan 18, 2022
There was a problem hiding this comment.
- Close the menu with the ✖️ button
- It should close and stay closed
I tried testing trunk in Firefox with touch simulation and closing worked ok. Not sure why 🤔
But I did still get the issue with the profile menu opening and also can see the warning in the console.
This fixes those issues. It looks like there was a small problem with the package.json so I pushed a fix.
Thanks for tracking down the micromodal problem and resolving the issue!
|
Doesn't this need to be backported to 5.9? |
talldan
added
the
Backport to WP Minor Release
|
@carolinan The last backports for 5.9 have already been done. I've added the label to make sure it's included in 5.9.1. |
|
I know the time zones are problematic, but I don't think 5.9 should ship a broken default theme. |
|
I was unable to reproduce the issue in Twenty Twenty-Two. I thought you mentioned the same thing in your comment: It's certainly not a great bug, but I don't know why it only affects certain themes. I did mention this issue to @noisysocks (editor release lead) already, btw. |
|
Since there are 9 more issues remaining in the 5.9 must-haves board, I assume there will be more backports for 5.9. We have a few hours to go for the next RC and a few days for the final release... |
I meant it was not exclusive to Twenty Twenty-Two. That it is not a theme issue. |
|
Yeah, for the record we did encounter this issue during Twenty Twenty-Two dev: WordPress/twentytwentytwo#301 (review). We thought it was fixed in #36837, but if that didn't work then we should try getting this in. |
desrosj
pushed a commit
that referenced
this pull request
Jan 18, 2022
* Update `micromodal` to 0.4.10 to fix navigation close button * Update package lock Co-authored-by: Daniel Richards <[email protected]> (cherry picked from commit 5bad8e8)
desrosj
added a commit
that referenced
this pull request
Jan 18, 2022
…#38057) * Update `micromodal` to 0.4.10 to fix navigation close button * Update package lock Co-authored-by: Daniel Richards <[email protected]> (cherry picked from commit 5bad8e8) Co-authored-by: Kelly Dwan <[email protected]>
desrosj
pushed a commit
that referenced
this pull request
Jan 18, 2022
* Update `micromodal` to 0.4.10 to fix navigation close button * Update package lock Co-authored-by: Daniel Richards <[email protected]> (cherry picked from commit 5bad8e8)
desrosj
added a commit
that referenced
this pull request
Jan 18, 2022
…#38058) * Update `micromodal` to 0.4.10 to fix navigation close button * Update package lock Co-authored-by: Daniel Richards <[email protected]> (cherry picked from commit 5bad8e8) Co-authored-by: Kelly Dwan <[email protected]>
hellofromtonya
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the version of
micromodallibrary to0.4.10to bring in a fix that allowspreventDefaultagain, fixing the click-through behavior in browsers that emulate click events on touch events. See ghosh/Micromodal#488.Fixes #37996.
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)