Fix: PanelColorSettings renders an empty when a color setting is falsy. #38029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
|
Size Change: +12 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
jorgefilipecosta
deleted the
fix/rendeing-empty-color-picker-when-a-color-setting-is-falsy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check to the internal ColorGradientSettingsDropdown component that verifies if a setting is falsy and in that case renders nothing instead of rendering an unsable color picker.
Adds a check to PanelColorSettings to make sure we don't pass a setting with null properties when a setting is null.
How has this been tested?
I reverted #38006.
I went to to the social links block, enabled to the logo-only option, and verified the color option available was icon color and an empty option was not rendered.