Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore local environment .tool-versions configuration file #38013

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Ignore local environment .tool-versions configuration file #38013

merged 1 commit into from
Jan 17, 2022

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jan 16, 2022 •
edited
Loading

Description

The .tool-versions file configures one's local environment and should likely not be committed. Its format is defined by asdf-vm, and is similar to nvm, rvm, or rbenv. Ignoring this file will help ensure the configuration is not accidentally committed to the repository.

How has this been tested?

n/a

Screenshots

n/a

Types of changes

Task

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@dcalhoun
Ignore local environment .tool-versions configuration file
285d5da 
The `.tool-versions` file configures one's local environment and should
likely not be committed. Its format is defined by
[asdf-vm](https://asdf-vm.com), and is similar to
[nvm](https://github.com/nvm-sh/nvm), [rvm](https://rvm.io), or
[rbenv](https://github.com/rbenv/rbenv). Ignore this file will help
ensure the configuration is not accidentally committed to the
repository.
@dcalhoun dcalhoun added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Jan 16, 2022
@dcalhoun dcalhoun mentioned this pull request Jan 16, 2022
Merged
2 tasks
@dcalhoun dcalhoun marked this pull request as ready for review January 16, 2022 16:40
@dcalhoun dcalhoun requested a review from hypest January 16, 2022 16:40
hypest
hypest approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dcalhoun dcalhoun merged commit 59343ef into trunk Jan 17, 2022
@dcalhoun dcalhoun deleted the chore/ignore-tool-version-configuration branch January 17, 2022 18:00
@github-actions github-actions bot added this to the Gutenberg 12.5 milestone Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

Assignees
No one assigned
Labels
[Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
Gutenberg 12.5
Development

Successfully merging this pull request may close these issues.
2 participants
@dcalhoun @hypest