Fix draft previews #37952
Merged
Fix draft previews #37952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 11, 2021 13:26
- Fixes issue with draft post not previwable if the draft was previously published. - During preview link creation, check if current post is in draft status.
- Add end to end test for issue WordPress#33616: Draft post not previewable if the draft was previously published.
- Include a link to the issue that the test validates. - Use aria-label instead of css class as a selector for Title field. - Update test title to be more descriptive about the case under test.
jorgecontreras
requested review from
ajitbohra,
nerrad and
ntwb
as code owners
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jorgecontreras! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
github-actions
bot
added
the
First-time Contributor
7 tasks
talldan
added
[Feature] History
talldan
approved these changes
Jan 14, 2022
There was a problem hiding this comment.
This was previously reviewed on a fork where the PR was accidentally created (Automattic#1), so for anyone looking for more background worth reading that.
Thanks @jorgecontreras for your work here. Also props to @getdave for reviewing that original PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #33616: Draft post not previewable if the draft was previously published.
When the post gets published, an autosave record is generated. Then, if the post is switched to Draft, the generated autosave record becomes stale. Subsequent edits to the post will reflect in the parent record, but not in the autosave record. This condition causes the preview to display the outdated content from the autosave record, which is not up to date with more recent edits. To solve this, the status of the post will be checked during preview link creation and if it's a draft, the autosave record will be ignored.
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist: