Improve flaky draft creation navigation block e2e test #37931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
talldan
changed the title
getdave
reviewed
Jan 13, 2022
| expect( console ).toHaveErroredWith( | ||
| 'Failed to load resource: the server responded with a status of 404 (Not Found)' | ||
| ); | ||
| expect( console ).toHaveErrored(); |
There was a problem hiding this comment.
Or if we want to be extra clear about the error we're expecting we could do a substring match. Probably not worth it though. toHaveErrored is probably good enough.
Suggested change
| expect( console ).toHaveErrored(); | |
| expect( console ).toHaveErroredWith( | |
| expect.stringContaining( 'Failed to load resource' | |
| )); |
|
@talldan Looking at the failure artifacts it seems that the
Otherwise why would the preview exist? That would likely mean the endpoint didn't return 404 and thus your test will fail. Why that happens is another question... Testing this flow manually the rich preview response is a 404:
|
I think it has to be returning a 404, otherwise the test would fail earlier at the The inconsistency seems to be in the console logging. It might be that there's sometimes a small delay in console logging. I wonder if moving this expect to the end of the test would improve things. |
|
I discovered some issues with the
I've also moved the |
|
Re-running the tests to make sure it's not flaky!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #37479.
I don't really understand the error message output by this test:
It seems to indicate that the console mock function is still called, but it has no message. It's unusual, but if this is the case the test can probably use
expect( console ).toHaveErrored()instead ofexpect( console ).toHaveErroredWith().