Add transform between core/site-logo and core/site-title blocks #37920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +60 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
Mamaduka
added
[Block] Site Logo
ntsekouras
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Thanks for the PR @richtabor!
Code wise this looks good. Initially this threw me off a bit as I have mentally mapped transformations to/from blocks by keeping existing content. On the other hand I believe these two blocks are really connected(interchangeable(?)) in many designs and that there is no harm at all to implement them and adds value.
I'm going to approve this one, but before merging I'd like some thoughts maybe from @jameskoster or @jasmussen that have thought a lot about such flows.
|
Whoah, that's quite a transform! Seems good to me: transforms are so full of untapped potential, and I'd love to see the interface for transforming evolved to embrace that fact. Clicking the block icon to see what options, styles, transform, pattern conversions, or layout options are available at any given moment, it could be big! That's just to say: I hope we can improve the transforms interface as a whole, so it can better contextualize the available transforms and help imply what it's all about. But in the mean time, this seems cool to me — you can always undo! Thanks for the PR! |
|
I think of similar transformations as "replace with" action 😄 |
This was referenced Apr 12, 2022
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37919 by adding a transform between the site logo and site title blocks.
Description
Added block transforms between the
core/site-logoandcore/site-titleblocks.Screenshots
CleanShot.2022-01-12.at.11.57.02.mp4
Types of changes
Add block transforms between the site-logo and site-title blocks.