Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Late escape Social block #37881

Merged
merged 3 commits into from
Jan 14, 2022
Merged

Late escape Social block #37881

merged 3 commits into from
Jan 14, 2022

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Jan 11, 2022

Description

This is not a security problem. This PR simply moves escaping of all PHP output to be as "late" as possible. This means we avoid escaping variables until they are output in the HTML markup.

This is a WP Core best practice.

How has this been tested?

  • add blocks
  • check functionality is "as was"
  • check all tests pass

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@getdave getdave added [Type] Code Quality Issues or PRs that relate to code quality [Block] Social Affects the Social Block - used to display Social Media accounts [Type] Security Related to security concerns or efforts labels Jan 11, 2022
@getdave getdave requested a review from mkaz as a code owner January 11, 2022 14:59
@getdave getdave self-assigned this Jan 11, 2022
@Mamaduka Mamaduka self-requested a review January 14, 2022 06:48
@getdave
Copy link
Contributor Author

getdave commented Jan 14, 2022

This PR now becomes "renaming a variable" and "removing a space character" so I'm not fussed about merging it. I guess we could if folks feel it's worth while 😄

@getdave getdave merged commit 3eb3d1d into trunk Jan 14, 2022
@getdave getdave deleted the update/late-escape-social-blocks branch January 14, 2022 14:37
@github-actions github-actions bot added this to the Gutenberg 12.5 milestone Jan 14, 2022
@getdave getdave mentioned this pull request Feb 7, 2022
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Code Quality Issues or PRs that relate to code quality [Type] Security Related to security concerns or efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants