Reduce specificity of legacy font sizes defined by core #37819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Bug
|
@Mamaduka @noisysocks I've milestoned this one for 5.9, in case you think there's still leeway to include it. |
aristath
approved these changes
Jan 10, 2022
|
Size Change: -16 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Thanks for working on this, @oandregal.
Changes make sense to me as well. I'm going to add Backport label.
Mamaduka
added
the
Backport to WP 6.7 Beta/RC
|
Thanks for staying on this. This seems like a good step forward, and it's always nice to see specificity lowered. |
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #37617
There's an issue by which legacy font sizes (normal & huge) provided by core override the theme classes in WordPress 5.9 (or using the Gutenberg plugin).
Why it happens
.has-<slug>-font-size { font-size: value; }.has-<slug>-font-size { font-size: var(--wp--preset--font-size-<slug>) !important; }normalandhugeat Font sizes: update default values #37381 Because we still need to make them available for old content, those classes were moved back to the old bundle. However, they still have an!importantthat makes it difficult for others to override, which doesn't make sense for a legacy default.The fix
For the two legacy font sizes (
normalandhuge) we should reduce the specificity back to what it was:.has-<slug>-font-size { font-size: value; }.How to test
The expected result is that the paragraph font size is the one defined by the theme,
21px. If using the plugin from thetrunkbranch, what happens is that the font size is16pxinstead.