Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marking test that consistently fails as skipped. #37729

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Marking test that consistently fails as skipped. #37729

merged 1 commit into from
Jan 5, 2022

Conversation

ryanwelcher
Copy link
Contributor

@ryanwelcher ryanwelcher commented Jan 5, 2022 •
edited
Loading

Description

Based on @youknowriad comment here - #37446 (comment). This test has been consistently falling and blocking PRs

Types of changes

Marks a test as skipped.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@ryanwelcher ryanwelcher added the [Package] E2E Tests /packages/e2e-tests label Jan 5, 2022
@ryanwelcher
Copy link
Contributor Author

Related #36746, #37446

@ryanwelcher ryanwelcher mentioned this pull request Jan 5, 2022
Merged
@ryanwelcher ryanwelcher requested a review from Mamaduka January 5, 2022 17:47
Mamaduka
Mamaduka approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ryanwelcher.

@ryanwelcher ryanwelcher mentioned this pull request Jan 5, 2022
Merged
7 tasks
@ryanwelcher ryanwelcher merged commit fe9b08a into WordPress:trunk Jan 5, 2022
@github-actions github-actions bot added this to the Gutenberg 12.4 milestone Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

Assignees
No one assigned
Labels
[Package] E2E Tests /packages/e2e-tests
Projects
None yet
Milestone
Gutenberg 12.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanwelcher @Mamaduka