Update yargs dependency for @wordpress/env to fix CVE-2021-3807.
#37601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Type] Bug
| ## 4.1.3 (2021-11-07) | ||
|
|
||
| ### Bug Fix | ||
|
|
||
| - Fix Xdebug installation code to ensure it would fail gracefully | ||
| - Fix Xdebug installation code to ensure it would fail gracefully |
There was a problem hiding this comment.
These spaces were inserted automatically by the pre-commit formatting/linting.
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
ZebulanStanphill
force-pushed
the
fix/wordpress-env-dep-vulnerability
branch
3 times, most recently
from
d8a8b83 to
588c901
Compare
Fixes minor vulnerability in dependency tree: https://nvd.nist.gov/vuln/detail/CVE-2021-3807
ZebulanStanphill
force-pushed
the
fix/wordpress-env-dep-vulnerability
branch
from
588c901 to
a8d29db
Compare
glendaviesnz
approved these changes
Dec 23, 2021
There was a problem hiding this comment.
This tested well for me. I was able to run wp-env start --xdebug and connect to xdebug successfully, and then running wp-env start turned it back off again. Including parameters, eg. --xdebug=profile,trace,debug also worked, but unknown params --xdebug=santa caused an error. New tests also passed.
|
@glendaviesnz Thanks for the quick test! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed while working on another project that there was a minor vulnerability in my dependency tree:
The cause was
@wordpress/envusing an outdated version ofyargswhich meant it was indirectly relying on an outdated version ofansi-regex, which had a minor regex vulnerability: https://nvd.nist.gov/vuln/detail/CVE-2021-3807I have no clue if the issue is even relevant to
@wordpress/env, but it annoyed me to see the issue when I would runnpm auditon my own project, so I decided to whip up a fix real quick.How has this been tested?
It hasn't. I'm not sure if I can test
wp-envsince I've had trouble in the past getting it to even work normally. If anyone could properly test this for me, that would be very helpful.I did take a look at the only file using
yargs(packages/env/lib/cli.js), and I found that thecoercecallbacks are now receivingundefinedvalues, so I updatedparseXdebugModeto account for that.Types of changes
Updated dependency to fix minor vulnerability.
Checklist:
*.native.jsfiles for terms that need renaming or removal).