Fix: Gradients are not being applied by class #37597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
Size Change: +326 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
oandregal
approved these changes
Dec 23, 2021
jorgefilipecosta
deleted the
fix/gradients-are-not-being-applied-by-class
branch
ntsekouras
reviewed
Dec 27, 2021
| export function __experimentalUseGradient( { | ||
| gradientAttribute = 'gradient', | ||
| customGradientAttribute = 'customGradient', | ||
| } = {} ) { | ||
| const { clientId } = useBlockEditContext(); | ||
|
|
||
| const gradientsPerOrigin = useSetting( 'color.gradients' ) || EMPTY_OBJECT; | ||
| const userGradientPalette = useSetting( 'color.gradients.custom' ); |
There was a problem hiding this comment.
Can you explain a bit why useSetting( 'color.gradients' ) wouldn't work? Is it because we want to remove support for retrieval of top level settings(which this is not) and a combination of custom handling for some settings, origin priority and deprecated fallbacks? Do we have a problem/different handling for other settings?
I saw a lot of connected PRs about this but I don't have much context in this area and would like to understand it better.
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Jan 4, 2022
Co-authored-by: André <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that made the preset gradients not applied by class but by custom value.
How has this been tested?
I added a group block I selected a theme gradient.
I added a cover block I selected a default gradient.
I verified on the code editor both gradients were applied using a class (on trunk they are not).