-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Site Editor]: Register block editor shortcuts #37577
Merged
ntsekouras
merged 1 commit into
trunk
from
fix/register-block-editor-keyboard-shortcuts-to-site-editor
Dec 22, 2021
Merged
[Site Editor]: Register block editor shortcuts #37577
ntsekouras
merged 1 commit into
trunk
from
fix/register-block-editor-keyboard-shortcuts-to-site-editor
Dec 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
An existing feature does not function as intended
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
labels
Dec 22, 2021
ntsekouras
requested review from
mcsf,
Mamaduka,
youknowriad,
mtias,
aristath,
gziolo and
jorgefilipecosta
December 22, 2021 08:13
Size Change: +13 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Nik! The fix works as expected.
Mamaduka
reviewed
Dec 22, 2021
ellatrix
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me.
ntsekouras
deleted the
fix/register-block-editor-keyboard-shortcuts-to-site-editor
branch
December 22, 2021 09:31
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Jan 4, 2022
noisysocks
pushed a commit
that referenced
this pull request
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #33948
It seems we never registered the block editor shortcuts in site editor and this PR does just that.
Testing instructions
Notes
Examples can be found in block settings in a block's toolbar:
The full list of the block editor shortcuts is here in code.