Send non-deprecated language tags from Android in initialProps #37565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wordpress-mobile/gutenberg-mobile#4368
By default, the Android/Java Locale class uses deprecated language codes for Hebrew and Indonesian in order to not break backwards compatibility. But Gutenberg uses the new language codes, which prevented the proper translations from being picked up for those languages on Android. This updates Android to instead send the new language codes to Gutenberg in the initial props.
I'm applying this fix on the Android native side because (1) it allows me to use
Locale::toLanguageTag
to "revert" the change in the language code. This felt right to me since it is the Locale class itself that was switching to the deprecated language code and causing this problem in the first place.How has this been tested?
Note that this has to be tested via WPAndroid (relevant PR) because language changes are not picked up in the demo app.
Screenshots
Types of changes
Bugfix
Checklist:
*.native.js
files for terms that need renaming or removal).