Simplify the embed loading state #37548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Size Change: -429 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
I like this. Once we update spinners it'd look even better. Do we need to check if this class is used for anything else? |
mtias
approved these changes
Dec 21, 2021
From a quick search, it looks like the |
|
I think there may be some issues with navigation / links on trunk. I'm not seeing the spinner there at all... I'm sure there used to be one. Either way, this PR behaves the same as trunk in that regard. The widgets I tested seem fine, although the Archives one does seem to spit out a "Block rendered as empty" message rather than a loading state. That is the same on trunk though. |
Exactly. I don't know if the current behavior is the optimal or intended one, but this PR does not seem to introduce any regressions 👍 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #37523.
This PR removes all visual styling from the embed block loading state, showing just the spinner.
Before:
embed-before.mp4
After:
embed-after.mp4