Add comment-form and comment-list to default html5 theme support #37536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e with comment layout caused by this change
glendaviesnz
added
[Feature] Themes
glendaviesnz
requested review from
ajitbohra,
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: +6 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
Thanks for adding this one in @glendaviesnz! This is testing nicely for me in blocks based themes (TwentyTwentyTwo and TT1-Blocks) and also tested to make sure there's no issues in a few classic themes (TwentyTwenty, TwentyNineteen, Maywood).
LGTM!
andrewserong
added
the
[Type] Bug
|
@hellofromtonya If this looks ok to you, do we just merge and add the backport tag to get the CSS change into 5.9? |
|
Thanks for ping @glendaviesnz. The changes look good. Let me pull it down and see how TT2 renders. If all is good, then I'll approve in a couple of minutes. |
hellofromtonya
approved these changes
Dec 21, 2021
|
@glendaviesnz The PHP change resyncs with Core. The CSS change shifts the comments back into alignment. The package update will need to happen to backport the CSS to Core. |
hellofromtonya
added
the
Backport to WP 6.7 Beta/RC
tellthemachines
pushed a commit
that referenced
this pull request
Dec 21, 2021
…e with comment layout caused by this change (#37536) Co-authored-by: Glen Davies <[email protected]>
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds comment-form and comment-list to default html5 theme support for compatibility with core 5.9 and fixes comment layout issue caused by this change.
Fixes: #37464
How has this been tested?
Ran 5.9 beta 3 without Gutenberg plugin and checked comment markup
Ran Gutenberg plugin on 5.8 with this PR applied and checked that comment markup matched 5.9 beta 3, and that comment layout was correct
Screenshots
Before:
After:
Without the CSS change in this PR the comment avatar alignment is incorrect:
so check that these are in alignment with parent post width.