-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate receiveUploadPermissions #37508
deprecate receiveUploadPermissions #37508
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jiteshdhamaniya! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
I thought the code can be safely removed altogether because it‘s not exposed publicly. |
I think everything that's exported is public API> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @jiteshdhamaniya! 👍
Congratulations on your first merged pull request, @jiteshdhamaniya! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
IIRC this function was never exported publicly outside of the package, so other packages could not use it. Hence the suggestion to completely remove this code |
Sorry if I misunderstand something. Developers could access this action using the example below, making it a public API: const { receiveUploadPermissions } = useDispatch( 'core' ); |
Ah, right, missed that. My bad. |
Description
This PR Solves #33900.
receiveUploadPermissions
is not used anymore so this PR makes it deprecated and suggests to usereceiveUserPermission
instead.How has this been tested?
receiveUploadPermissions
in all Gutenberg files, and found no reference, except declaration file.receiveUploadPermissions
and tested site to confirm everything is working.Screenshots
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).