Add proper padding to ColorGradientControl #37502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +15 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
I tweaked the padding of the .components-color-palette__custom-color as well:
|
|
Thanks for the effort! Since it's touching also the color palette component, I'd love a sanity check from @ciampo or @mirka (not urgent), and we might need a changelog note. Wanted to also note that the failing tests will likely pass after a rebase, since #37501 has been merged. Visually, this looks like a good small improvement to what's shipping in trunk and seems fine to land. One of the longer term efforts we have is to move towards some of the designs outlined in #35093, with more intently designed popovers, specifically ones where the color palettes or custom swatches can go edge to edge. One of the challenges we need to solve there is figuring out our popover styles, whether we can go borderless with a shadow and clearer eye-dropper symbol, or whether we need to integrate some border of delineation with the canvas. Notably this mockup takes a not entirely successful stab at merging the edge-to-edge elements with a border. Right now there are a few diverging styles going on, with an opportunity to unify and simplify, and I'm excited for us to get to that. In the mean time, as a small padding change, this feels great. |
mirka
added
[Package] Block editor
mirka
reviewed
Dec 21, 2021
Comment on lines
+2
to
+3
| padding: $grid-unit-10; | ||
|
|
There was a problem hiding this comment.
Since this component can be used in other (e.g. not in a popover) contexts as well, I think it would be better not to give it inherent padding, and instead make the consumer component responsible for adding whatever padding is desired.
For example, we could add a padding wrapper div here:
This way we only affect our specific dropdown use case.
|
Closing as this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds missing padding to the ColorGradientControl Dropdown, so that it is consistent with other Dropdown within the editor, and gives the UI visual space from the edge of the dropdown.
Screenshots
Before
After
Reference
Types of changes
CSS