Block editor: Fix Enter handling for nested blocks #37453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -35 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
ellatrix
requested review from
adamziel,
ajitbohra,
draganescu,
kevin940726,
mkaz,
noisysocks,
talldan and
tellthemachines
as code owners
ellatrix
added
[Type] Bug
|
It could have been a perf optimization a long time ago but now looking up the parent is very fast so I think it doesn't matter to pass or not that information. |
youknowriad
approved these changes
Dec 16, 2021
youknowriad
added
the
Backport to WP 6.7 Beta/RC
ellatrix
force-pushed
the
fix/enter-nested-block
branch
from
b458e7b to
194b6f6
Compare
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
tellthemachines
pushed a commit
that referenced
this pull request
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #37445.
The problem is that we don't pass the root client ID to
getBlockIndex.I do wonder why we make it necessary to pass this information, because it can be derived from the client ID.I changed
getBlockIndexso you no longer have to pass the root client ID. Client IDs are unique, so there can only be only root client ID for a given client ID. Removing this parameter makes it less likely for people to forget to pass it or pass the wrong one and for there to be bugs as a result. It also makes the code usinggetBlockIndexless verbose.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).