Template Editor: Change color of welcome dialog close icon so it is visible against black background #37435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Bug
|
Size Change: +74 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
Thanks for the fix @glendaviesnz
✅ The close icon color is updated to white for the template editor welcome dialog
❓ This also impacts the welcome dialog for the post editor, is that intended?
Screenshots
Template Editor
Post Editor
| Before | After |
|---|---|
 |
 |
glendaviesnz
force-pushed
the
fix/template-welcome-close-color
branch
from
2b821da to
7acca8f
Compare
aaronrobertshaw
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
I've retested this and the icon color change now only applies to the template editor welcome 👍
Regarding your question on hover state, it will be a trivial change to add something that perhaps drops the brightness of the icon on hover e.g. filter: brightness(0.85); so I think that can be tweaked later if needed.
glendaviesnz
force-pushed
the
fix/template-welcome-close-color
branch
from
7acca8f to
13fca97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default color of the close icon is dark grey, so it is barely visible against the black background of the template editor welcome dialog, so this PR changes the color of the icon to white.
Fixes: #37399
How to test
Screenshots
Before:
After:
