Navigation: Refactor modal padding to be simpler and more flexible. #37323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: +90 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Dec 13, 2021
|
Thank you! |
jasmussen
added
the
Backport to WP 6.7 Beta/RC
|
Adding the backport label both since it's harmless bugfix, but also because TT2 could make good use of this. |
This was referenced Dec 15, 2021
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
tellthemachines
pushed a commit
that referenced
this pull request
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The padding inside the navigation modal overlay is using a pixel based padding, which makes it tricky to style without also needing to move the abs positioned close button. This image shows how the close button is abs positioned to make things line up:
This PR refactors the padding inside the modal to be
2em, and to uniformly affect the container that holds both the close button and the content both. That makes it a fair bit easier to style the padding:How has this been tested?
Insert a navigation menu, make it open in a modal, and observe the close button and menu looking right.
Checklist:
*.native.jsfiles for terms that need renaming or removal).