Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoiding some code duplication #37155

Closed
wants to merge 2 commits into from
Closed

Avoiding some code duplication #37155

wants to merge 2 commits into from

Conversation

matiasbenedetto
Copy link
Contributor

@matiasbenedetto matiasbenedetto commented Dec 6, 2021 •
edited
Loading

Description

Avoiding some code duplication in Query Pagination Previous and Next blocks
@ntsekouras

How has this been tested?

Wordpress 5.8.2
Gutenberg latest trunk version

Screenshots

Types of changes

Just a minimal refactor no functionality is changed

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@matiasbenedetto matiasbenedetto mentioned this pull request Dec 6, 2021
Closed
3 tasks
@skorasaurus skorasaurus added the [Type] Code Quality Issues or PRs that relate to code quality label Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiasbenedetto @skorasaurus