-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E Tests: Increase delay in image block e2e test to fix intermittent failure when clearing url field #37136
E2E Tests: Increase delay in image block e2e test to fix intermittent failure when clearing url field #37136
Conversation
…re when clearing url field
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the image e2e tests several times in a row on my local machine and they passed every time.
I can't see why we couldn't push these changes, even if it means the tests fail less often 😄
Thank you!
Thanks for testing @ramonjd! It's a small change, but 🤞 it improves reliability here a little bit. I'll merge it in 👍 |
Description
This PR implements the suggestion from @aaronrobertshaw in #36982 (comment) to increase the delay when clearing the input field in the Image block's e2e test. While testing locally, we noticed intermittent test failures in the clearing of the URL field, and slightly increasing the delay appears to improve the reliability without adding too much time to the test.
How has this been tested?
Locally, before checking out this PR, and after starting up
wp-env
and runningnpm run dev
, run the following:Before this PR, the tests pass for me most of the time. However, after running the above command 5 or 6 times, it starts to fail with the error shown in the screenshot below.
With this PR applied, the tests appear to pass consistently in my local environment.
Screenshots
This is the intermittent error message I would sometimes get prior to this PR. Note that in the "received" string, the UUID-based filename still appears in the URL and has not been cleared, so the target url has been appended to that string. In the expected string, the UUID filename is replaced with
/wp-includes/images/w-logo-blue.png
.Types of changes
Code quality / test reliability.
Checklist:
*.native.js
files for terms that need renaming or removal).