Fix @wordpress/comment-case ESlint errors but without adding the disable-rule pragma
#37006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
force-pushed
the
fix/eslint-errors-no-disable
branch
from
2139d07
to
59e7c64
Compare
opr
requested review from
adamsilverstein,
adamziel,
ajitbohra,
cameronvoell,
dmsnell,
draganescu,
ellatrix,
getdave,
guarani,
gziolo,
kevin940726,
mkevins,
mmtr,
nerrad,
noahtallen,
noisysocks,
ntwb,
oandregal,
swissspidy,
talldan and
tellthemachines
as code owners
opr
changed the title
@wordpress/comment-case ESlint errors but without adding the disable-rule pragma
|
There is one failing JS unit test:
I bet it's caused by the changes in the source file used in the test fixture. It's probably enough to regenerate the test snapshot. |
opr
force-pushed
the
fix/eslint-errors-no-disable
branch
from
3d44583
to
a16e0ac
Compare
Open
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a cleanup of code comments that don't conform to the new
@wordpress/comment-caserule.It is Related to #36866 but the comments such as
eslint-disable-next-lineetc. are removed.How has this been tested?
It is based off #36866 and I manually inspected every file there, this PR just removes the comments that disable the ESLint rule, I didn't test all of the other files.
Types of changes
This PR only changes comments, no functionality would be affected.
Checklist:
*.native.jsfiles for terms that need renaming or removal).