Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Extract TableOfContents as reusable component #3639

Merged
merged 1 commit into from
Nov 24, 2017

Conversation

youknowriad
Copy link
Contributor

Extract a reusable TableOfContents to the editor/components folder.
Needed to be able to separate the edit-post and editor module

Testing instructions

  • Check that the "info" button style works (header toolbar)

@youknowriad youknowriad self-assigned this Nov 24, 2017
@youknowriad
Copy link
Contributor Author

Expect some similar PRs today, I'm going to merge them as soon as the tests pass, they consist of moving some files around.

@codecov
Copy link

codecov bot commented Nov 24, 2017

Codecov Report

Merging #3639 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3639      +/-   ##
==========================================
+ Coverage    36.8%   36.85%   +0.04%     
==========================================
  Files         268      268              
  Lines        6649     6640       -9     
  Branches     1201     1201              
==========================================
  Hits         2447     2447              
+ Misses       3550     3541       -9     
  Partials      652      652
Impacted Files Coverage Δ
editor/components/table-of-contents/index.js 0% <ø> (ø)
editor/edit-post/header/header-toolbar/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b19f4f...5d0cbdd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant