Gallery: Make sure the mobile warning notice only runs when images are added to a new block #36326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
the
[Block] Gallery
|
Size Change: +6 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
|
I tested this by:
The message appears on a cleared cache only when I insert one or more images. After both dismissing and ignoring the message (with a page refresh) I no longer see the message until I clear my local cache. I don't think the perf test is related as it complains about trashing posts (?) |
apeatling
approved these changes
Nov 8, 2021
glendaviesnz
force-pushed
the
fix/mobile-warning-notice-bug
branch
from
5b11d07 to
85f2033
Compare
…o a new gallery block
glendaviesnz
force-pushed
the
fix/mobile-warning-notice-bug
branch
from
85f2033 to
7992786
Compare
andrewserong
added
the
Backport to WP 6.7 Beta/RC
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 10, 2021
…o a new gallery block (#36326) Co-authored-by: Glen Davies <[email protected]>
andrewserong
pushed a commit
that referenced
this pull request
Nov 10, 2021
…o a new gallery block (#36326) Co-authored-by: Glen Davies <[email protected]>
|
Cherry picked into the Gutenberg 11.9 release in: 369a056 |
andrewserong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the new warning added to alert users to mobile app compatibility issues with the new gallery block also shows if you mouse over the Gallery block preview. This PR makes sure it only runs if images are added to a new gallery block.
How has this been tested?
Screenshots
Before:
After:
