Add spacing attributes to comment author avatar #36322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +45 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
gziolo
added
[Block] Comment Template
gziolo
reviewed
Nov 9, 2021
There was a problem hiding this comment.
It looks like this PR is on track. @oandregal, is there a better way for spacing handling in PHP? useSpacingProps usage in the edit function is very convenient, it would be super nice to have something similar in PHP.
cbravobernal
force-pushed
the
update/add_spacing_attributes_comment_author_avatar
branch
from
81a4369 to
691c0a9
Compare
cbravobernal
deleted the
update/add_spacing_attributes_comment_author_avatar
branch
gziolo
reviewed
Nov 29, 2021
| @@ -45,7 +61,10 @@ function render_block_core_comment_author_avatar( $attributes, $content, $block | |||
| 'class' => $classes, | |||
| ) | |||
| ); | |||
| return $avatar_string; | |||
| if ( isset( $spacing_attributes ) ) { | |||
| return sprintf( '<div style="%1s">%2s</div>', $spacing_string, $avatar_block ); | |||
There was a problem hiding this comment.
One thing that came up to my mind. Should we sanitize the computed string for the style?
There was a problem hiding this comment.
Yep, seems a good idea. Should I create a new PR, right?
There was a problem hiding this comment.
Yes, that's the best way to move forward. It's also why a proper API would be better as we would have a central place to address this type of concers 😄
Yeah, we should extract utility functions from the "apply" functions in block supports. Aaron had a PR that also needed it for typography #36104 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR, we are adding spacing attributes (margin and padding) to the Comment Author Avatar.
We include specific PHP code in order to apply some styles to the wrapper and other styles to the image tag.
Please, feel free to propose a better solution if possible, as I could not find any core function that provides the attribute non serialized in a style HTML attribute string.
Maybe is a good idea to include a function to return scoped styles and classes with supports fields in block.json attributes. For example:
`get_scoped_style_and_classes(['spacing', 'border']);
I would be happy to work on that function if is a good approach.
How has this been tested?
Screenshots
Editor:
Frontend:
.