Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Author Name: Add spacing to have same options as Post Author Name #36213

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Comment Author Name: Add spacing to have same options as Post Author Name #36213

merged 2 commits into from
Nov 5, 2021

Conversation

cbravobernal
Copy link
Contributor

@cbravobernal cbravobernal commented Nov 4, 2021 •
edited
Loading

Description

Add spacing to comment author name to have same options as post author name.
Suggestion to do
PR with the post author name options

How has this been tested?

  • Created a comment loop
  • Change margin and padding to a comment author name block
  • Check that is applied both in editor/frontend

Screenshots

Editor:
editor

Frontend:
frontend

Types of changes

Small new feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.

@gziolo gziolo added [Block] Comment Template Affects the Comment Template Block [Type] Enhancement A suggestion for improvement. labels Nov 4, 2021
gziolo
gziolo approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍🏻

@gziolo gziolo merged commit d81307a into trunk Nov 5, 2021
@gziolo gziolo deleted the update/feature-parity-comment-author-post-author branch November 5, 2021 07:35
@gziolo gziolo changed the title Update - Add spacing to comment author name to have same options as post author name Comment Author Name: Add spacing to comment author name to have same options as post author name Nov 5, 2021
@github-actions github-actions bot added this to the Gutenberg 11.9 milestone Nov 5, 2021
@gziolo gziolo changed the title Comment Author Name: Add spacing to comment author name to have same options as post author name Comment Author Name: Add spacing to have same options as Post Author Name Nov 5, 2021
@cbravobernal cbravobernal self-assigned this Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@carolinan carolinan Awaiting requested review from carolinan

@DAreRodz DAreRodz Awaiting requested review from DAreRodz

Assignees

@cbravobernal cbravobernal

Labels
[Block] Comment Template Affects the Comment Template Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 11.9
Development

Successfully merging this pull request may close these issues.
2 participants
@cbravobernal @gziolo