Improve unit test coverage for REST API menus endpoints. #36177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
added
Core REST API Task
spacedmonkey
requested review from
adamziel,
noisysocks,
TimothyBJacobs and
anton-vlasenko
spacedmonkey
commented
Nov 3, 2021
| @@ -479,21 +479,23 @@ protected function prepare_item_for_database( $request ) { | |||
| } | |||
| } | |||
|
|
|||
| $error = new WP_Error(); | |||
There was a problem hiding this comment.
This is not needed, but makes debugging easier, as you can see multiple errors in REST API response.
spacedmonkey
commented
Nov 3, 2021
| @@ -324,7 +324,7 @@ public function update_item( $request ) { | |||
| * Deletes a single menu item. | |||
| * | |||
| * @param WP_REST_Request $request Full details about the request. | |||
| * @return true|WP_Error True on success, or WP_Error object on failure. | |||
| * @return WP_REST_Response|WP_Error True on success, or WP_Error object on failure. | |||
There was a problem hiding this comment.
This return type was wrong.
spacedmonkey
commented
Nov 3, 2021
| if ( 'block' === $prepared_nav_item['menu-item-type'] ) { | ||
| if ( empty( $prepared_nav_item['menu-item-content'] ) ) { | ||
| return new WP_Error( 'rest_content_required', __( 'Content required if menu item of type block.', 'gutenberg' ), array( 'status' => 400 ) ); | ||
| if ( 'block' === $prepared_nav_item['menu-item-type'] && empty( $prepared_nav_item['menu-item-content'] ) ) { |
There was a problem hiding this comment.
No need for two if statements here.
spacedmonkey
commented
Nov 3, 2021
| $links['https://api.w.org/object'][] = array( | ||
| 'href' => rest_url( $path ), | ||
| 'post_type' => $menu_item->type, | ||
| $key => $type, |
There was a problem hiding this comment.
This was incorrect, this is a bug fix.
spacedmonkey
commented
Nov 3, 2021
| } | ||
|
|
||
| if ( $path ) { | ||
| if ( $path && $type ) { | ||
| $links['https://api.w.org/object'][] = array( |
There was a problem hiding this comment.
@TimothyBJacobs did you want to change this?
There was a problem hiding this comment.
Yeah, let's change the type to menu-item-object
|
Looks good, thanks. Yeah let's just adjust that menu item link relation. |
TimothyBJacobs
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve unit test coverage for REST API menus endpoints.
Bug fixes and tweaks to code to improve code.
Final tweaks, before core merge.
Fixes #34992