[data]: Rename types file from .d.ts to .ts #36062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on #35869 I discovered that the module where we keep some top-level type definitions is named with the `.d.ts` suffix as if it were a manually-maintained types definition file. It's capable of being a normal TypeScript module though, and my IDE was having a bit of trouble with the `.d.ts` suffix - not because that was wrong, but I think because it was different than what the IDE expected. In this patch all we're doing is renaming the file in order to smooth this over and clean up later type-related patches that will occur to the data package. Updating `tsconfig.json` was necessary becuase of the rename so that TypeScript will appropriately find and use these types.
sirreal
reviewed
Oct 29, 2021
| @@ -17,5 +17,6 @@ | |||
| "src/redux-store/metadata/**/*", | |||
| "src/promise-middleware.js", | |||
| "src/utils", | |||
| "src/*.ts" | |||
There was a problem hiding this comment.
This could probably be src/**/*.ts, I expect TypeScript files anywhere are expected to be included 🙂
There was a problem hiding this comment.
I'll update that when I actually start using .ts files in there. How does that sound?
sarayourfriend
added
[Package] Data
|
I've rebuilt the project and it appears like the generated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on #35869 I discovered that the module where we keep some
top-level type definitions is named with the
.d.tssuffix as if itwere a manually-maintained types definition file.
It's capable of being a normal TypeScript module though, and my IDE was
having a bit of trouble with the
.d.tssuffix - not because that waswrong, but I think because it was different than what the IDE expected.
In this patch all we're doing is renaming the file in order to smooth
this over and clean up later type-related patches that will occur to
the data package. Updating
tsconfig.jsonwas necessary becuase of therename so that TypeScript will appropriately find and use these types.
How has this been tested?
There should be no change in the bundled JavaScript code. There should be
no functional or visual changes.
❓ Could this impact any third-party projects dependent on
@wordpress/data?We need to verify that this generates the same type definitions for the package
as it previously did.
Types of changes
Renaming a module holding type definitions.
Checklist:
*.native.jsfiles for terms that need renaming or removal).