Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to show empty terms #36010

Conversation

pbearne
Copy link
Contributor

@pbearne pbearne commented Oct 27, 2021

Fixes #35489

Description

Add an option to show empty terms

Screenshots image

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • [ x] My code is tested.
  • [x ] My code follows the WordPress code style.
  • [x ] My code follows the accessibility standards.
  • [ x] I've tested my changes with keyboard and screen readers.
  • [ x] My code has proper inline documentation.
  • [x ] I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@pbearne pbearne requested a review from ajitbohra as a code owner October 27, 2021 19:43
@skorasaurus skorasaurus added the [Block] Categories Affects the Categories Block label Dec 29, 2021
@carolinan
Copy link
Contributor

Hi @pbearne!
I tried to re-run the tests, but was not able to. I think the failing tests may be related to the test fixtures, which needs to be updated because of the added attributes in block.json.

@skorasaurus
Copy link
Member

Thanks for your initial work on this; it was completed in #39426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Categories Affects the Categories Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No "hide_empty" setting on Categories block
3 participants