Navigation Editor: show a warning when trying to save unsupported blocks #35993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-vlasenko
requested review from
adamziel,
draganescu,
getdave,
kevin940726,
talldan and
tellthemachines
as code owners
|
Size Change: +766 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
anton-vlasenko
added
[Package] Edit Navigation
Developer Experience
gziolo
reviewed
Oct 27, 2021
| .filter( ( { block } ) => ! isBlockSupportedInNav( block ) ) | ||
| .map( ( { block } ) => block.name ); | ||
| if ( unsupportedMenuItems.length ) { | ||
| logWarning( |
There was a problem hiding this comment.
This function exists for development purposes, to show warnings in the development mode related to code.
There was a problem hiding this comment.
@gziolo Ah, I see. It's not going to work in the browser because process.env.NODE_ENV won't be defined.
Should we simply use console.warn instead?
Do you have a better alternative?
There was a problem hiding this comment.
Yes, console.warn should work. We might have usage of it also in other places.
…e it's not going to work in the browser. It's intended to be used with Node.
anton-vlasenko
changed the title
anton-vlasenko
changed the title
|
Thank you for the review, @draganescu ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Navigation editor only processes a subset of blocks in the editor, silently omitting anything that's not supported.
It would be useful to log a warning and make any problems there apparent.
Fixes #35045.
How has this been tested?
I had trouble reproducing this, so I've just replaced
gutenberg/packages/edit-navigation/src/store/utils.js
Line 80 in 92bf5e6
with
to emulate unsupported blocks.
3. Open the menu in the Navigation editor. Try to save it.
4. You should see a similar message in your browser console:
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).