Skip flaky test for loading block stylesheets in iframe #35961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
|
@youknowriad is there any convention around the process of skipping flaky tests? It seems like this is an unstable test so worth disabling to improve dev workflows in short term but in long term how are we tracking skipped tests? |
This was referenced Oct 26, 2021
getdave
deleted the
try/disable-flaky-iframe-block-stylesheets-e2e-test
branch
|
I don't know of any process, I try to ping folks that are most familiar with said tests. cc @ellatrix |
|
It would be good to create an issue for skipped tests and assign someone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #35394 (comment)
Description
This PR disables a flaky test that no one can currently debug. See #35394 (comment)
How has this been tested?
Run test suite. Make sure it's skipped.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).